En:Talk:Crop Growth Calendars

本页面用于讨论 En:Talk:Crop Growth Calendars.
将新留言放在已有留言的下方。在你的留言的末尾输入四个波浪符（~~~~）来签名和标注时间。	保持礼貌。与他人善意相待。不要删除已有讨论。

Ancient Fruit (Deluxe Speed-Gro) should have 22 days

The calendar for Ancient Fruit, Deluxe Speed-Gro mentions that the fruit is fully grown after 20 days. This should be 22 days. I tested this in Stardew Valley 1.5 multiple times. Does anybody else have the same result in their game? The stages are as follows in my game for Ancient Fruit with Deluxe Speed-Gro.

Growth phases
Stage	Days
Stage 1	1 days
Stage 2	5 days
Stage 3	5 days
Stage 4	6 days
Stage 5	4 days

Maiken (talk) 18:41, 29 March 2021 (UTC)

You are absolutely correct, I've updated the page with the correct stages. Thanks so much! margotbean (talk) 18:53, 29 March 2021 (UTC)

Speed-Gro Glitch

Apart from Speed-Gro Mechanics, there's another bug in ConcernedApe's codes. When he calculated the days to be removed, he didn't consider the situation where days of the stage is less than 0 day.

Let's take grape as an example. The stage of grape is {1, 1, 2, 3 ,3} in the crops.xnb. When we have Hyper Speed-Gro and Agriculturist at the same time, the speed increase should be 0.43. 0.43 * (1+1+2+3+3) = 4.3 ≈ 5. Therefore, 5 days should be removed from the grapes' growth stage. It should take 5 days to grow and can be harvested on the 6th day. The following is the normal process:

{1, 1, 2, 3 ,3} --step 1--> {1, 0, 2, 3 ,3} --step 2-->

{1, 0, 1, 3 ,3} --step 3--> {1, 0, 1, 2 ,3} --step 4-->

{1, 0, 1, 2 ,2} --step 5--> {1, 0, 0, 2 ,2}

While in the code and game, the actual process is:

... --step 4-->

{1, 0, 1, 2 ,2} --step 5--> {1, -1, 1, 2 ,2}

Therefore, the grapes take 1 + 0 + 1 + 2 + 2 = 6 days to grow, and can be harvested on the 7th day. I have tested this in the game, and it actually takes 6 days to grow.

The growth calendar of grapes is now correct. The purpose of editing this topic is to explain how this happened. Horizon98 (talk) 16:38, 20 April 2021 (UTC)

Using module to replace this page

I have completed a module to output crop growth calendars, see Module:Crop Growth Calendars. And it works well now. You can see the page using this module here: User:Horizon98/Sandbox. I have compared the sandbox and Crop Growth Calendars, everything works well. Furthermore, translating this page can be very easy. Just translate the table Dictionary of the Module (only 30 words or sentences need to be translated), and then all calendars are translated. See this page on zh wiki: 作物生长日历.

Besides, the 25% Irrigated table of Unmilled Rice is incorrect now. It should take 4 days to grow instead of 5 days. I have tested in the game. Horizon98 (talk) 16:39, 20 April 2021 (UTC)

I have also tested all crops' growths with and without Agriculturist, and updated the English page accordingly. At this point, all one needs to do is copy the information to the other languages in a text editor, skipping the parts that are already translated. This is on my "to do" list, as soon as I can get through checking other edits and fixing other problems.

I appreciate that you put the work into creating the module, but implementing it in the other languages would be more work than has already been done. In addition, it reflects the current 1.5 code, but would need to be updated to reflect any future changes in the code, so it doesn't really help there.

Please remember to discuss any major changes like this before implementing them. I can't stress that enough. It takes hours to keep the wikis maintained and consistent, and undoing changes made without discussion detracts from the time that could be spent updating pages. Thank you for your work, margotbean (talk) 19:05, 20 April 2021 (UTC)

Firstly, I don't think translating such a complex page could be simpler than translate only 30 keys in the dictionary table (about 50 English words totally). And I have translated the module to Chinese successfully. This page takes more than 300,000 bytes now, which is too large to edit. When I edit the whole page in Chrome now, there's even a delay more than 1 second after I typing words. If necessary, I will help with this translation on other language wikis. Furthermore, updating the translation of other languages' pages could be much easier, see the second point.

Secondly, if there are more crops in the future, it's convenient to add new crop data from crops.xnb into the data table. The code should be updated when there are other types of speed-gro or something else that change the speed increase. But it's not complex, I can write the method in the document. Besides, this module also support returning only one single table when use the "mode" argument. It's simpler than updating the current page in this situation.

Thirdly, I didn't implement any major change except for updating the 作物生长日历 and copying [[template:Addlanglinks]] to zh wiki, because there's no one else to talk with on zh wiki :( and these changes work well. You have undone these changes, but I don't think these operations will take you more than 15 minutes.

Fourthly, ~~the module is still a draft~~ (edited). So I start a discussion here, and I haven't edited any major change on the English wiki.

Fifthly, the 25% Irrigated table of Unmilled Rice is incorrect as I said before. You can test this in the game.

At last, thanks for all your work to maintain and update this wiki. Horizon98 (talk) 06:45, 21 April 2021 (UTC)

Taro Root's season

Taro Root grows in summer, but this page classifies this crop as Other Crops. I think that it could be moved to Summer Crops. Horizon98 (talk) 10:43, 22 April 2021 (UTC)

Carrot Tables Row Height

The Agriculturist and Speed-Gro Comparison tables are displaying at different sizes. This is because the Deluxe Speed-Gro & Hyper Speed-Gro for Agriculturist have a harvest every day except the first day; the images of the carrot stages and the carrot crop are different heights, causing the tables to be smaller for those 2 tables. I would like to fix the row height for those tables at 48px to match the other tables but wanted to discuss here before making the changes. I've uploaded a photo to show the difference between what is showing by default and the changes I would like to put in place. Let me know if this formatting change is alright to make. Thank you!!! KrobusFanClub (talk) 07:25, 7 May 2024 (UTC)

Hello again KFC! Your solution would work, but I thought it would be better to set the vertical alignment to "top", like the Hops' tables (and Ancient Fruit). While I was researching how to answer your query, I found it was easier to just make the change. So it should be all fixed, let me know if you have any other issues. And thank you for your kind words! margotbean (talk) 19:04, 7 May 2024 (UTC)